Aliases for internal vulnerabilites #5699:Fix suggestion#5709
Open
anton-jj wants to merge 5 commits intoDependencyTrack:masterfrom
Open
Aliases for internal vulnerabilites #5699:Fix suggestion#5709anton-jj wants to merge 5 commits intoDependencyTrack:masterfrom
anton-jj wants to merge 5 commits intoDependencyTrack:masterfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
2 tasks
added 5 commits
January 26, 2026 09:26
Improve vulnerability creation by validating alias data and synchronizing the first provided alias with the persistence layer. This ensures that internal, CVE, GHSA, and OSV identifiers are captured consistently when aliases are supplied. The update also prevents missing or incomplete alias information from silently passing through the creation workflow. Signed-off-by: Anton Jäppinen Johansson <antja@westermo.com>
Ensure alias data is validated and consistently updated when modifying an existing vulnerability. The logic now initializes missing alias lists, applies incoming alias fields when provided, and synchronizes the resulting alias with the persistence layer. This prevents stale or incomplete alias records from remaining attached to updated vulnerabilities. Signed-off-by: Anton Jäppinen Johansson <antja@westermo.com>
Remove the internal identifier from the first alias when deleting an internal vulnerability. This prevents stale alias references from remaining after the vulnerability record is removed and ensures that alias data does not incorrectly point to a non‑existent internal vulnerability. Signed-off-by: Anton Jäppinen Johansson <antja@westermo.com>
Small change to get the aliases instead of getting the whole vulnerability again Signed-off-by: Anton Jäppinen Johansson <antja@westermo.com>
updated synching aliases with jsonVuln instead of persistentVuln Signed-off-by: Anton Jäppinen Johansson <antja@westermo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a suggestion on solution for aliases for connecting internal aliases with existing CVE, GHSA, OSV.
Addressed Issue
Fixes #5699,
Fronted issue: DependencyTrack/frontend#458
Additional Details
This is a suggestion on solution for aliases, issue with this is that if a internal alias is related to a CVE and GHSA if one off those is removed from the internal alias the relationship between those are removed (CVE -> GHSA).
This does not affect the current frontend, since alias for internal vulnerabilities are disabled.
I will make a PR for the frontend also adding needed functionality.
Checklist