Skip to content

Complete notification publishing migration#1624

Merged
nscuro merged 1 commit intomainfrom
notification-workflow
Jan 28, 2026
Merged

Complete notification publishing migration#1624
nscuro merged 1 commit intomainfrom
notification-workflow

Conversation

@nscuro
Copy link
Copy Markdown
Member

@nscuro nscuro commented Jan 4, 2026

Description

Completes the notification publishing migration.

  • Enables notification router and removes feature flag.
  • Implements dex workflow for publishing.
  • Removes direct publishing to Kafka.
  • Adds partial rule filtering at notification emission time.

Addressed Issue

N/A

Additional Details

Hyades PR: DependencyTrack/hyades#1977
Frontend PR: DependencyTrack/hyades-frontend#386

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro nscuro added this to the 5.7.0 milestone Jan 4, 2026
@nscuro nscuro added the enhancement New feature or request label Jan 4, 2026
@nscuro nscuro force-pushed the notification-workflow branch 2 times, most recently from 7d54fee to fd362ac Compare January 4, 2026 19:46
@nscuro nscuro force-pushed the notification-workflow branch 20 times, most recently from 1b4b2b4 to a33c5be Compare January 6, 2026 11:07
@nscuro nscuro force-pushed the notification-workflow branch from a33c5be to 2912943 Compare January 6, 2026 15:30
@nscuro nscuro force-pushed the notification-workflow branch from 2912943 to ba9889f Compare January 6, 2026 15:38
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Jan 6, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.21% (target: -1.00%) 72.58% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (28613d3) 36568 30660 83.84%
Head commit (3bba529) 36953 (+385) 30905 (+245) 83.63% (-0.21%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1624) 897 651 72.58%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@nscuro nscuro force-pushed the notification-workflow branch from 9e3b068 to 566f7eb Compare January 9, 2026 23:11
@nscuro nscuro mentioned this pull request Jan 10, 2026
2 tasks
@nscuro nscuro force-pushed the notification-workflow branch 24 times, most recently from 5aadc41 to 0671185 Compare January 15, 2026 21:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR completes the migration from direct Kafka-based notification publishing to a Dex workflow-based approach. It introduces significant architectural changes to the notification subsystem, including workflow-based publishing, rule filtering at emission time, and configuration schema versioning for vulnerability data sources.

Changes:

  • Migrates notification publishing from direct Kafka publishing to Dex workflow execution
  • Renames configuration classes to include V1 suffix for versioning (e.g., OsvVulnDataSourceConfigOsvVulnDataSourceConfigV1)
  • Adds JSON schema $id fields and implements stricter runtime config validation
  • Introduces database migrations for notification rule and publisher schema changes (NOTIFY_ON to array, config to JSONB)

Reviewed changes

Copilot reviewed 140 out of 148 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
proto/src/main/proto/.../argument_notification.proto New protobuf definitions for notification workflow arguments
proto/src/main/proto/.../argument_common.proto Replaced Java enum with protobuf message for DeleteFilesArgument
vuln-data-source//src/**/.java Updated config class references to V1-suffixed versions
notification/publishing/src/**/*.java Refactored publishers to support global/rule config split and updated tests
migration/.../changelog-v5.7.0.xml Added migrations for notification schema changes (NOTIFY_ON array, JSONB config)
dex/engine-api/src/**/*.java Unified task worker APIs (Activity/Workflow → TaskWorker)
apiserver/src/**/*.java Integrated Dex workflow for notification publishing and removed Kafka topics
Comments suppressed due to low confidence (1)

proto/src/main/proto/org/dependencytrack/internal/workflow/v1/argument_common.proto:32

  • The file path in the diff header appears to be incorrect. This file shows a complete replacement of Java code with protobuf definitions, but the file extension doesn't match the content. The file path suggests it's argument_common.proto but the content shows this is actually defining notification workflow arguments, not common arguments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread migration/src/main/resources/migration/changelog-v5.7.0.xml Outdated
Comment thread migration/src/main/resources/migration/changelog-v5.7.0.xml Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 140 out of 148 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

* Enables notification router and removes feature flag.
* Implements dex workflow for publishing.
* Removes direct publishing to Kafka.
* Adds partial rule filtering at notification emission time.

Signed-off-by: nscuro <nscuro@protonmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

breaking change enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants