Complete notification publishing migration#1624
Conversation
7d54fee to
fd362ac
Compare
1b4b2b4 to
a33c5be
Compare
a33c5be to
2912943
Compare
2912943 to
ba9889f
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
9e3b068 to
566f7eb
Compare
5aadc41 to
0671185
Compare
There was a problem hiding this comment.
Pull request overview
This PR completes the migration from direct Kafka-based notification publishing to a Dex workflow-based approach. It introduces significant architectural changes to the notification subsystem, including workflow-based publishing, rule filtering at emission time, and configuration schema versioning for vulnerability data sources.
Changes:
- Migrates notification publishing from direct Kafka publishing to Dex workflow execution
- Renames configuration classes to include V1 suffix for versioning (e.g.,
OsvVulnDataSourceConfig→OsvVulnDataSourceConfigV1) - Adds JSON schema
$idfields and implements stricter runtime config validation - Introduces database migrations for notification rule and publisher schema changes (NOTIFY_ON to array, config to JSONB)
Reviewed changes
Copilot reviewed 140 out of 148 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| proto/src/main/proto/.../argument_notification.proto | New protobuf definitions for notification workflow arguments |
| proto/src/main/proto/.../argument_common.proto | Replaced Java enum with protobuf message for DeleteFilesArgument |
| vuln-data-source//src/**/.java | Updated config class references to V1-suffixed versions |
| notification/publishing/src/**/*.java | Refactored publishers to support global/rule config split and updated tests |
| migration/.../changelog-v5.7.0.xml | Added migrations for notification schema changes (NOTIFY_ON array, JSONB config) |
| dex/engine-api/src/**/*.java | Unified task worker APIs (Activity/Workflow → TaskWorker) |
| apiserver/src/**/*.java | Integrated Dex workflow for notification publishing and removed Kafka topics |
Comments suppressed due to low confidence (1)
proto/src/main/proto/org/dependencytrack/internal/workflow/v1/argument_common.proto:32
- The file path in the diff header appears to be incorrect. This file shows a complete replacement of Java code with protobuf definitions, but the file extension doesn't match the content. The file path suggests it's
argument_common.protobut the content shows this is actually defining notification workflow arguments, not common arguments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 140 out of 148 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* Enables notification router and removes feature flag. * Implements dex workflow for publishing. * Removes direct publishing to Kafka. * Adds partial rule filtering at notification emission time. Signed-off-by: nscuro <nscuro@protonmail.com>
Description
Completes the notification publishing migration.
Addressed Issue
N/A
Additional Details
Hyades PR: DependencyTrack/hyades#1977
Frontend PR: DependencyTrack/hyades-frontend#386
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effective