Skip to content

Remove clean goal from build and install make targets#1821

Merged
nscuro merged 1 commit intomainfrom
nscuro-patch-1
Feb 27, 2026
Merged

Remove clean goal from build and install make targets#1821
nscuro merged 1 commit intomainfrom
nscuro-patch-1

Conversation

@nscuro
Copy link
Copy Markdown
Member

@nscuro nscuro commented Feb 27, 2026

Description

Remove clean goal from build and install make targets.

There is a separate clean make target already.

Addressed Issue

N/A

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Signed-off-by: Niklas <nscuro@protonmail.com>
@nscuro nscuro added this to the 5.7.0 milestone Feb 27, 2026
Copilot AI review requested due to automatic review settings February 27, 2026 20:33
@nscuro nscuro added the dx Issues related to developer experience (DX) label Feb 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s developer build workflow by stopping make build and make install from implicitly running a Maven clean, relying instead on the existing dedicated make clean target.

Changes:

  • Remove clean from the Maven invocation in the build make target.
  • Remove clean from the Maven invocation in the install make target.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Makefile
Comment thread Makefile
@codacy-production
Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 18e1df61 (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (18e1df6) Report Missing Report Missing Report Missing
Head commit (d978fcf) 38005 31850 83.80%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1821) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@nscuro nscuro merged commit aa5f76d into main Feb 27, 2026
15 checks passed
@nscuro nscuro deleted the nscuro-patch-1 branch February 27, 2026 20:52
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dx Issues related to developer experience (DX)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants