Skip to content

Address zizmor GitHub Actions findings#1942

Merged
nscuro merged 1 commit intomainfrom
zizmor-fixes
Mar 27, 2026
Merged

Address zizmor GitHub Actions findings#1942
nscuro merged 1 commit intomainfrom
zizmor-fixes

Conversation

@nscuro
Copy link
Copy Markdown
Member

@nscuro nscuro commented Mar 27, 2026

Description

Fixes findings identified by zizmor (https://github.com/zizmorcore/zizmor)

Addressed Issue

N/A

Additional Details

N/A

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Fixes findings identified by zizmor (https://github.com/zizmorcore/zizmor)

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro added this to the 5.7.0 milestone Mar 27, 2026
Copilot AI review requested due to automatic review settings March 27, 2026 01:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens repository automation to address security findings flagged by zizmor, primarily by reducing credential persistence and preventing expression injection in run scripts across GitHub Actions workflows.

Changes:

  • Disable persisted GitHub credentials in multiple actions/checkout steps (persist-credentials: false) to reduce token exposure risk.
  • Move untrusted/expandable GitHub context values into env: variables before using them in shell scripts (mitigates expression injection findings).
  • Tighten/clarify workflow permissions and adjust release publishing to use the built-in GITHUB_TOKEN where appropriate.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/mirror-container-image.yml Moves registry package fields into env for safer shell usage when mirroring images.
.github/workflows/dependency-review.yaml Disables persisted checkout credentials.
.github/workflows/ci-test-pr-coverage.yml Uses env variables for Codacy token/commit SHA before invoking reporting script.
.github/workflows/ci-release.yaml Removes custom checkout token usage; uses env indirection for inputs in the release step.
.github/workflows/ci-publish.yaml Disables persisted checkout credentials; adds contents: write where needed; switches GH release edits/uploads to GITHUB_TOKEN.
.github/workflows/ci-openapi.yaml Disables persisted checkout credentials in both jobs.
.github/workflows/ci-lint.yaml Adds explicit empty top-level permissions and disables persisted checkout credentials.
.github/workflows/buf.yml Disables persisted checkout credentials.
.github/workflows/_meta-build.yaml Uses env indirection for workflow-call inputs used in shell script logic.
.github/dependabot.yml Adds a cooldown block to Dependabot update configurations.
Comments suppressed due to low confidence (1)

.github/workflows/ci-release.yaml:87

  • MAVEN_ARGS is built and exported based on workflow inputs, but the mvn release:prepare invocation doesn’t actually use it. Unless Maven is expected to consume MAVEN_ARGS implicitly (it usually doesn’t), the release-version, development-version, and dry-run inputs won’t have any effect. Consider either passing the constructed arguments to mvn explicitly or removing the dead argument-building logic.
          MAVEN_ARGS="-B"
          if [[ -n "${INPUT_RELEASE_VERSION}" ]]; then
            MAVEN_ARGS="${MAVEN_ARGS} -DreleaseVersion=${INPUT_RELEASE_VERSION}"
          fi
          if [[ -n "${INPUT_DEVELOPMENT_VERSION}" ]]; then
            MAVEN_ARGS="${MAVEN_ARGS} -DdevelopmentVersion=${INPUT_DEVELOPMENT_VERSION}"
          fi
          if [[ "${INPUT_DRY_RUN}" == "true" ]]; then
            MAVEN_ARGS="${MAVEN_ARGS} -DdryRun=true"
          fi
          export MAVEN_ARGS

          mvn release:prepare

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nscuro nscuro merged commit d89d895 into main Mar 27, 2026
14 checks passed
@nscuro nscuro deleted the zizmor-fixes branch March 27, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants