Account for changed list extensions API response#494
Merged
Conversation
The array field is now names "items" instead of "extensions", analogue to how all other collection resources work in API v2. Signed-off-by: nscuro <nscuro@protonmail.com>
2 tasks
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes. Give us feedback
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the frontend to match an API v2 response change for listing notification publisher extensions, where the collection field is now items instead of extensions.
Changes:
- Update notification publisher extension list handling to read from
response.data.items. - Adjust template creation modal to populate available extensions from
items. - Update admin menu extension loading logic to use
itemsfor extension-point collections.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/views/administration/notifications/Publishers.vue | Reads the notification publisher extensions collection from response.data.items. |
| src/views/administration/notifications/CreateTemplateModal.vue | Uses items to populate the extension selector for template creation. |
| src/views/administration/AdminMenu.vue | Switches extension-point menu population to use response.data.items. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Accounts for changed list extensions API response.
The array field is now names "items" instead of "extensions", analogue to how all other collection resources work in API v2.
Addressed Issue
N/A
Additional Details
API server PR: DependencyTrack/hyades-apiserver#2012
Checklist
This PR introduces new or alters existing behavior, and I have updated the documentation accordingly