Add ADR-017: Notification Filter Expressions#2127
Merged
Conversation
Signed-off-by: nscuro <nscuro@protonmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Merged
3 tasks
Up to standards ✅🟢 Issues
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new architecture decision record (ADR-017) documenting the planned introduction of CEL-based notification filter expressions, and wires it into the MkDocs navigation so it appears in the published docs.
Changes:
- Add ADR-017 document: “Notification Filter Expressions”
- Add ADR-017 to the “Architecture → Decisions” section of
mkdocs.yml
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| mkdocs.yml | Adds ADR-017 to the documentation navigation tree. |
| docs/architecture/decisions/017-notification-filter-expressions.md | Introduces ADR-017 describing CEL-based notification filter expressions, validation, fail-open behavior, and caching. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds ADR-017: Notification Filter Expressions.
Addressed Issue
Relates to DependencyTrack/dependency-track#3767
Additional Details
API server PR: DependencyTrack/hyades-apiserver#1924
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly