Updated docker #31
Open
Updated docker #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lation link format
…Dockerfile to use debian:bookworm-slim
… Docker image fix(Dockerfile): optimize Dockerfile by reordering COPY commands and adding cargo fetch step
…server and client in Docker
micheal-ndoh
requested review from
Dericko681,
Nkwenti-Severian-Ndongtsop and
Copilot
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- Dockerfile: Language not supported
Comments suppressed due to low confidence (1)
tests/README.md:1
- Typo found: 'direcotry' should be corrected to 'directory'.
//describe this direcotry
tests/README.md
Outdated
Comment on lines
5
to
6
| Run the Server explicity using the command: | ||
|
|
There was a problem hiding this comment.
Typo found: 'explicity' should be corrected to 'explicitly'.
Suggested change
| Run the Server explicity using the command: | |
| Run the Server explicitly using the command: |
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (1)
- Dockerfile: Language not supported
tests/README.md:1
- The word 'direcotry' appears to be misspelled; consider correcting it to 'directory'.
//describe this direcotry
There was a problem hiding this comment.
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Files not reviewed (1)
- Dockerfile: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/testmain.yml:21
- Please confirm that downgrading from actions/checkout@v4 to v3 is intentional, as v4 offers improved performance and security.
uses: actions/checkout@v3
README.md:75
- [nitpick] Consider using a consistent code block language specifier (e.g., 'rust') across the documentation to improve clarity.
```rs
Nkwenti-Severian-Ndongtsop
requested changes
Apr 5, 2025
There was a problem hiding this comment.
@micheal-ndoh
nice contribution but i noticed some slight errors
- The git clone command uses your URL account instead of this repo
- The command to run the image also uses your account name not this repo-name as well, because your building the image with the name of this repo but when running the image, you are using but your own repo name
OK thanks let me update that |
Nkwenti-Severian-Ndongtsop
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated dockerfile to use chatme binary as entry point and serve the server implicitly on running the container
Fixes #21
Fixes #22
Fixes #25