[WIP] If item tier overlay is missing, fall back to displaying the tier number #11594
+34
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Tested with different item icon sizes as well and it correctly stays centered under the seasonal banner. Initial impl checked against tier > 5, but checking against overlay being missing for that tier instead seemed like the better option re: "this is a fallback case" |
bhollis
reviewed
Nov 22, 2025
Contributor
bhollis
left a comment
bhollis
left a comment
There was a problem hiding this comment.
I'm not sure this is actually necessary long-term (and haven't we capped tier at 5 when creating items already?). But if we want to keep it, let's make the number less gigantic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Display item tiers greater than 5 as a number (if there is no tier pip icon given by Bungie)