Add +colN perk column search with quote-safe parsing and autocomplete#11872
Open
delphiactual wants to merge 2 commits into
Open
Add +colN perk column search with quote-safe parsing and autocomplete#11872delphiactual wants to merge 2 commits into
delphiactual wants to merge 2 commits into
Conversation
Lets perk:/perkname:/exactperk: restrict matches to specific perk columns via a +colN suffix (e.g. rangefinder+col3, repeatable as +col3+col4), counting an item's visible perk columns from the left. - Re-attach a trailing +colN run to a quoted filter's args in the lexer so perkname:"firefly"+col3 works the same as the unquoted form (the suffix otherwise fell outside the quotes and was silently dropped). - Autocomplete +col1..+col5 as soon as a `+` is typed right after a perk value, with or without quotes and without a separating space. Scoped to perk filters, so multiquery `+` filters like dupe: are unaffected. - Tests: parsePerkColumns units, real-item column filtering (incl. the quoted regression), lexer snapshots, and autocomplete + dupe cases. Changelog: Perk searches can now target a specific perk column, e.g. perkname:rangefinder+col3.
- perkColumnCompletion: the partial-selector group was captured but unused (regexp/no-unused-capturing-group) - make it non-capturing. - freeform.test.ts: ItemFilter<DimItem> -> ItemFilter (DimItem is the default).
Contributor
|
I don't really think specific-column searches make sense. Don't you think it'd be nicer to have a "perks that can be selected together" search e.g. |
Contributor
|
One example could be if you want to search guns with a damage perk in the left column |
Contributor
|
I mean, I guess I won't fight it too hard but targeting specific columns seems extremely niche vs. expressing what you want more directly (e.g. "I want both of these perks to be usable at once") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets perk:/perkname:/exactperk: restrict matches to specific perk columns via a +colN suffix (e.g. rangefinder+col3, repeatable as +col3+col4), counting an item's visible perk columns from the left.
+is typed right after a perk value, with or without quotes and without a separating space. Scoped to perk filters, so multiquery+filters like dupe: are unaffected.Closes #11724