Allow returning empty path in Steam_Apps::GetAppInstallDir()#233
Merged
Conversation
…path in `Steam_Apps::GetAppInstallDir()`
Contributor
|
Great job! I've tested the Naruto game mentioned in the issue (AppID 495160), and your solution works perfectly. |
Owner
|
If u dont mind adding a comment in app:paths saying this behavior would be good |
Collaborator
Author
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some games like appid 1113560 request DLC paths by
GetAppInstallDir()API but for some reasons real steam returns 0 and fills nothing to the path buffer, and such games actually expect this behavior to properly load DLC content or they will either miss DLC models or simply crash. However, current code indicates other games may instead requiring proper paths to be set to load DLCs. So I end up with this solution that makes emu acceptapp:pathslines like "1337=" to indicate we deliberately set such DLC path to be empty to resolve both problems.Related issue: #232 . After testing that game and making sure it works, I will set this PR as ready.