Fix lobby join callback flow and improve lobby discovery synchronization#497
Fix lobby join callback flow and improve lobby discovery synchronization#497Rustbeard86 wants to merge 2 commits into
Conversation
|
Enjoy my AI generated PR |
|
The failing Windows matrix leg looks transient rather than PR-related. I checked the exact target:
Across the last 12 So this does not currently look like a code regression from this PR. Separately, there is a real workflow bug in
are run before
That does not appear to be the cause of this specific failed matrix leg, but it is still incorrect workflow setup. Potential resolution:
Given the recent history for this exact matrix target, I would currently treat the failed upload as transient unless it reproduces on rerun. |
|
Still not working on #395 |
Summary
This PR fixes the post-discovery join path for lobby-based multiplayer and improves early lobby discovery synchronization.
What Changed
Networking sockets callback flow
ISteamNetworkingUtilsConnectP2P/ConnectByIPAddressbeginsLobby discovery synchronization
Lobby_Messages::DATA_REQUESTWhy
The previous behavior allowed the client to discover the host lobby, but the join flow could still stall in a long retry or timeout cycle because the expected networking callback path was not being delivered to the game.
In parallel, lobby discovery relied too heavily on passive propagation. The added synchronization path makes initial lobby visibility and targeted lobby refresh more reliable during early peer setup.
Verification
devapi_regularsuccessfully on the rebased branchRelated Issues
May address or improve
#162,#339, and#395based on matching symptoms in the join path and lobby visibility flow.May also improve
#265, but that has not been verified.