-
Notifications
You must be signed in to change notification settings - Fork 92
Update MacOS platform description in README #1744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MacOS platform description in README #1744
Conversation
📝 WalkthroughWalkthroughUpdated README.md to rename the MacOS compatibility row from "MacOS ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @README.md:
- Line 34: Update the README entry that currently reads "MacOS (Apple Silicon /
`aarch64`)" to use the official Apple branding "macOS (Apple Silicon /
`aarch64`)"—locate the table row containing that string and change the
capitalization only, keeping the rest of the cell content (checkboxes and note)
unchanged.
- Line 34: The README was updated to remove x86_64 Darwin, but the Rust code
still contains support paths; either remove the x86_64 Darwin handlers from the
code or revert the doc change: specifically, if you intend to remove support,
delete the x86_64 Darwin branches and associated logic in src/settings.rs (the
user prefix configuration and init-system setup handlers for Darwin x86_64) and
the macOS planner creation in src/planner/mod.rs (the code that constructs the
macos_planner / create_macos_planner path); otherwise revert the README change
and add a deprecation note and timeline in README.md indicating continued
support until the handlers are removed.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
🧰 Additional context used
🪛 LanguageTool
README.md
[uncategorized] ~34-~34: The operating system from Apple is written “macOS”.
Context: ...) | ✓ | Stable | | MacOS (Apple Silicon / aarch64) ...
(MAC_OS)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: build-aarch64-linux / Build aarch64 Linux (static)
- GitHub Check: build-aarch64-darwin / Build aarch64 Darwin (static)
- GitHub Check: build-x86_64-linux / Build x86_64 Linux (static)
- GitHub Check: Lints
Description
Checklist
cargo fmtnix buildnix flake checkValidating with
install.determinate.systemsIf a maintainer has added the
upload to s3label to this PR, it will become available for installation viainstall.determinate.systems:Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.