Skip to content

Conversation

@grahamc
Copy link
Member

@grahamc grahamc commented Jan 13, 2026

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

Summary by CodeRabbit

  • Documentation
    • Clarified README platform compatibility: renamed MacOS entry to "macOS (Apple Silicon / aarch64)" and aligned related reference wording for consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 13, 2026

📝 Walkthrough

Walkthrough

Updated README.md to rename the MacOS compatibility row from "MacOS (x86_64 and aarch64)" to "macOS (Apple Silicon / aarch64)" and adjusted a Quirks reference link text to match the platform renaming.

Changes

Cohort / File(s) Change Summary
Documentation
README.md
Renamed MacOS compatibility table row to "macOS (Apple Silicon / `aarch64`)" and updated Quirks reference link text to match capitalization/wording.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • colemickens
  • lucperkins

Poem

🐰 A tiny tweak, a clearer name,
Apple Silicon claims its fame,
In README rows the letters dance,
Small change, bright clarity—hoppity prance!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating the MacOS platform description in the README file, specifically the capitalization and wording adjustments.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 95dd450 and f5a7633.

📒 Files selected for processing (1)
  • README.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: build-aarch64-darwin / Build aarch64 Darwin (static)
  • GitHub Check: build-x86_64-linux / Build x86_64 Linux (static)
  • GitHub Check: build-aarch64-linux / Build aarch64 Linux (static)
  • GitHub Check: Lints

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In @README.md:
- Line 34: Update the README entry that currently reads "MacOS (Apple Silicon /
`aarch64`)" to use the official Apple branding "macOS (Apple Silicon /
`aarch64`)"—locate the table row containing that string and change the
capitalization only, keeping the rest of the cell content (checkboxes and note)
unchanged.
- Line 34: The README was updated to remove x86_64 Darwin, but the Rust code
still contains support paths; either remove the x86_64 Darwin handlers from the
code or revert the doc change: specifically, if you intend to remove support,
delete the x86_64 Darwin branches and associated logic in src/settings.rs (the
user prefix configuration and init-system setup handlers for Darwin x86_64) and
the macOS planner creation in src/planner/mod.rs (the code that constructs the
macos_planner / create_macos_planner path); otherwise revert the README change
and add a deprecation note and timeline in README.md indicating continued
support until the handlers are removed.
📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d2feb98 and 95dd450.

📒 Files selected for processing (1)
  • README.md
🧰 Additional context used
🪛 LanguageTool
README.md

[uncategorized] ~34-~34: The operating system from Apple is written “macOS”.
Context: ...) | ✓ | Stable | | MacOS (Apple Silicon / aarch64) ...

(MAC_OS)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: build-aarch64-linux / Build aarch64 Linux (static)
  • GitHub Check: build-aarch64-darwin / Build aarch64 Darwin (static)
  • GitHub Check: build-x86_64-linux / Build x86_64 Linux (static)
  • GitHub Check: Lints

@grahamc grahamc enabled auto-merge (squash) January 13, 2026 21:06
@grahamc grahamc merged commit 3f166cd into main Jan 13, 2026
19 checks passed
@grahamc grahamc deleted the graham/cf-296-nix-installer-fixups-for-x86_64-darwin-drop branch January 13, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants