Calendar: Should switch to the last date view in multiple mode when value is changed (T1279950) #29358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d mode (T1279950)
r-farkhutdinov
force-pushed
the
25_1_T1279950
branch
from
f7c80ba to
ba5d3a9
Compare
ksercs
changed the title
ksercs
reviewed
Mar 20, 2025
| @@ -2015,15 +2036,15 @@ QUnit.module('Options', { | |||
|
|
|||
| [ | |||
| { | |||
| value: [new Date('01/05/2023'), new Date('02/01/2023')], | |||
| value: [new Date('02/01/2023'), new Date('01/05/2023')], | |||
There was a problem hiding this comment.
Could you please clarify why we need these changes?
| @@ -2106,7 +2136,7 @@ QUnit.module('Options', { | |||
| }); | |||
|
|
|||
| QUnit.test('It should be possible to deselect already selected value by click', function(assert) { | |||
| const $cell = $(getCurrentViewInstance(this.calendar).$element().find('*[data-value="2023/01/15"]')); | |||
| const $cell = $(getCurrentViewInstance(this.calendar).$element().find('*[data-value="2023/02/01"]')); | |||
There was a problem hiding this comment.
Same here. We should be able to deselect any date, why then it's so important to update here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.