refactor: eliminate duplicated buildDataRows and data-table query patterns - #9
Draft
DevItaliya22 with Copilot wants to merge 2 commits into
Draft
refactor: eliminate duplicated buildDataRows and data-table query patterns#9DevItaliya22 with Copilot wants to merge 2 commits into
DevItaliya22 with Copilot wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Add FileLoadedPayload type to csv-mapping.ts utility (moved from CsvHeaderMapping component, re-exported for compat) - Add buildDataRowsFromPayload() to csv-mapping.ts, eliminating identical buildDataRows useCallback in SkuImportSheet, CategoryImportSheet, BillImportSheet, CustomerImportSheet - Create hooks/useDataTableQuery.ts with generic useDataTableQuery<TResponse> hook - Simplify useCustomersQuery, useSkusQuery, useBillsQuery, useCategoriesQuery, useCampaignsQuery to delegate to useDataTableQuery Co-authored-by: DevItaliya22 <132957942+DevItaliya22@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor duplicated code for improved maintainability
refactor: eliminate duplicated buildDataRows and data-table query patterns
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two blocks of logic were copied verbatim across multiple files with no abstraction. This extracts each into a single shared location.
buildDataRowsFromPayload— 4 import sheets → 1 utilitybuildDataRowswas copy-pasted identically intoSkuImportSheet,CategoryImportSheet,BillImportSheet, andCustomerImportSheet. Extracted tolib/utils/csv-mapping.ts:FileLoadedPayloadwas also moved from the React component intocsv-mapping.ts(no React deps) and re-exported for backward compat.useDataTableQuery— 5 query hooks → 1 generic hookuseCustomersQuery,useSkusQuery,useBillsQuery,useCategoriesQuery, anduseCampaignsQueryall had the same body: read search params →getDataTableConfig→buildApiParams→useQuery. Extracted tohooks/useDataTableQuery.ts:💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.