순화 과정 AI 모델을 Gemini로 변경 (#183)#184
Merged
Merged
Conversation
seungchan2022
requested review from
Ssunbell,
UnkyungJo,
alstjr7437 and
doyeonyyy
as code owners
Closed
2 tasks
Ssunbell
reviewed
Aug 24, 2025
Comment on lines
+48
to
+53
| let content = """ | ||
| \(systemPrompt) | ||
|
|
||
| <입력> | ||
| \(inputText) | ||
| </입력> |
Collaborator
There was a problem hiding this comment.
이거는 system prompt, user prompt를 따로 넣지 않고 user prompt에 system prompt를 넣는 방식으로 하긴 해서 정확한 사용법은 아니지만, 최근 모델들은 user prompt에 system prompt를 넣어도 잘 해주더라고요! 그래서 문제는 아니지만 참고삼아 말씀드립니다!
Collaborator
Author
There was a problem hiding this comment.
감사합니다!! 한번 찾아 볼께요
seungchan2022
force-pushed
the
feat/#183
branch
from
cd1b640 to
f29907c
Compare
alstjr7437
requested changes
Aug 26, 2025
alstjr7437
left a comment
alstjr7437
left a comment
Collaborator
There was a problem hiding this comment.
고생하셨습니다!! 리뷰 확인 추후에 한번 부탁드려요!
Comment on lines
+5
to
+14
| static let shared = GeminiManger() | ||
|
|
||
| private let model: GenerativeModel? | ||
|
|
||
| init() { | ||
| let firebaseService = FirebaseAI.firebaseAI(backend: .googleAI()) | ||
| model = firebaseService.generativeModel( | ||
| modelName: "gemini-2.5-flash", | ||
| systemInstruction: ModelContent(role: "system", parts: systemPrompt)) | ||
| } |
Collaborator
There was a problem hiding this comment.
이렇게 init으로 만들면 shared로 결국 싱글톤이 아니고 어디서든 생성이 가능한거 아닌가요?!
Collaborator
Author
There was a problem hiding this comment.
private을 붙혔어야 했는데, 빠트렸네요
Comment on lines
+150
to
+154
| if #available(iOS 14.0, *) { | ||
| return AppAttestProvider(app: app) | ||
| } else { | ||
| return DeviceCheckProvider(app: app) | ||
| } |
Collaborator
There was a problem hiding this comment.
저희 어짜피 17이상 버전이라 14 아래는 안해줘도 되지 않나요?!
alstjr7437
approved these changes
Aug 26, 2025
Comment on lines
+21
to
+24
|
|
||
| let providerFactory = YourAppCheckProviderFactory() | ||
| AppCheck.setAppCheckProviderFactory(providerFactory) | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
승인되지 않은 클라이언트가 백엔드 리소스에 액세스하는 것을 방지하여 앱 백엔드를 악용으로부터 보호해 주기 위해 App Check를 추가해준 것 입니다.
아래 공식문서 첨부 하겠습니다.
App Check
App Attest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 PR Content
순화 과정을 Gpt 방식에서 Gemini를 이용한 방식으로 변경했습니다.