map macos scan code to windows scancode #496
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thenextman cc. |
|
Hi! Sorry for the delay here. I’ll be busy for a while, but I think I’ll be able to look into it on Friday or next Monday! |
|
Im also looking forward to this getting merged! Would it be possible for this to get reviewed soon? |
CBenoit
reviewed
Mar 12, 2025
| @@ -16,6 +16,6 @@ doctest = false | |||
| test = false | |||
|
|
|||
| [dependencies] | |||
| ironrdp-pdu.workspace = true | |||
| ironrdp-pdu = { workspace = true, features = ["std"] } | |||
There was a problem hiding this comment.
It seems that it’s not necessary to enable this feature here.
CBenoit
reviewed
Mar 12, 2025
There was a problem hiding this comment.
I still need to review more in depth, but it seems the PR is not complete. The mapping logic is not actually used anywhere. I think this is fine to do the integration in a separate PR if that is the intention though.
Overall things are looking reasonable, but some cleanup is required as some warnings are suppressed without a comment explaining why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
map macos scancode to windows', as mentioned Scancodes Mapping.
@CBenoit can u check this? only macos/EVDEV are supported for now.