refactor(pedm): cleanup and clippy

[allan2]

This resolves all clippy errors in the the devolutions-pedm crate.

[github-actions]

Let maintainers know that an action is required on their side

• Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

• Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

• Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

• Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

[CBenoit]

question: Why did you make everything public? Is it API we actually intended to expose from this crate? I believe not, because, for instance, this function is an HTTP handler. I would rather not increase the API surface of any crate more than necessary.

[allan2]

I figured it is simpler, because we control usage. There are no consumers of this crate at the moment. If you prefer, I can undo this commit to keep pub(crate).

[CBenoit]

I understand where you come from, but the problem is that there is no dead_code lint across crate boundaries. We are much more likely to keep around dead code if it’s publicly exposed from the crate. I also tend to prefer clear pub(crate) over pub when the item is never used outside of the crate, just so I have a clear idea on what is an API boundary (even if we are the only ones to use it).
That being said, the workspace unused pub items problem could be addressed with a tool such as https://github.com/cpg314/cargo-workspace-unused-pub
If we integrate it in our CI, this may become mostly a non issue (besides my preference for clearly marking a pub(crate) item as pub(crate)).

[CBenoit]

LGTM!