feat: set keyboard layout functionality #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacmancoder
commented
Mar 13, 2025
| | NOW_SET_KBD_LAYOUT_FLAG_NEXT<br>0x00000001 | Switches to next keyboard layout. kbdLayoutId field should contain empty string. Conflicts with NOW_SET_KBD_LAYOUT_FLAG_PREV. | | ||
| | NOW_SET_KBD_LAYOUT_FLAG_PREV<br>0x00000002 | Switches to previous keyboard layout. kbdLayoutId field should contain empty string. Conflicts with NOW_SET_KBD_LAYOUT_FLAG_NEXT. | | ||
|
|
||
| **kbdLayoutId (variable)**: NOW_STRING structure containing the keyboard layout identifier usually represented as [Windows Keyboard Layout Identifier](https://learn.microsoft.com/en-us/windows-hardware/manufacture/desktop/windows-language-pack-default-values) (HKL). |
There was a problem hiding this comment.
NOW_STRING type reasoning:
While technically we can use u32 here for Windows HKLs, I think it is useful to keep this field as string to allow simple extensibility in future for non-windows agent implementations.
pacmancoder
commented
Mar 13, 2025
| @@ -119,117 +119,62 @@ public void MsgBoxRspError() | |||
| Assert.Throws<NowProtocolException>(() => msg.GetResponseOrThrow()); | |||
| } | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
leftovers after recreating rust tests in C#, slipped past previous review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements new Agent RDP keyboard layout switcher functionality in the core protocol (spec/rust/C#) and C# client.