Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sspi): add client-server smoke test #407

Merged
merged 9 commits into from
Mar 27, 2025

Conversation

TheBestTvarynka
Copy link
Collaborator

@TheBestTvarynka TheBestTvarynka commented Mar 27, 2025

Hi,
I added a client-server smoke tests in this PR. Currently, they cover NTLM and CredSSP. I'll add Kerberos test too when the Kerberos server-side is implemented.
Moreover, I found a bug in credentials passing in the SspiContext implementation and fixed it (bbd005c).

@TheBestTvarynka TheBestTvarynka self-assigned this Mar 27, 2025
@TheBestTvarynka TheBestTvarynka requested a review from CBenoit March 27, 2025 08:58
@TheBestTvarynka TheBestTvarynka marked this pull request as ready for review March 27, 2025 08:58
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!!

@CBenoit CBenoit changed the title feat(tests): add client-server smoke test test(sspi): add client-server smoke test Mar 27, 2025
@CBenoit CBenoit enabled auto-merge (squash) March 27, 2025 15:31
@TheBestTvarynka
Copy link
Collaborator Author

I accidentally disabled auto merge 😅 I didn't mean it 😔

@CBenoit CBenoit merged commit 193f92a into master Mar 27, 2025
42 checks passed
@CBenoit CBenoit deleted the feat/client-server-smoke-test branch March 27, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants