Skip to content

Recursive version bump when using defines #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mount40 wants to merge 3 commits into
base: master
Choose a base branch
from
+19 −49
Open

Recursive version bump when using defines #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2d139e
Version bumping is done through a simple recursive filemtime check on…
mount40 Dec 23, 2019
887eb0d
Moved "max" function call, so now the recursive asset versiom bump fu…
mount40 Dec 23, 2019
030e7c1
Code refactor.
mount40 Dec 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions assets-version.js
View file
Open in desktop

This file was deleted.

22 changes: 19 additions & 3 deletions functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,25 @@
* @package DevriX_Starter
*/

// Dynamic grab master CSS mod time.
$master_modified_time = filemtime( get_theme_file_path() . '/assets/dist/css/master.min.css' );
define( 'DX_ASSETS_VERSION', $master_modified_time . '-0000' );
/*
* Recursive auto version bump function.
* Loops through all assets in the supplied folder and returns the
* latest date of modification.
*/
function dx_get_assets_version( $dir ) {
Copy link
Contributor

@xavortm xavortm Dec 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add function description, do not glue it to the file description on top

$riterator = new RecursiveIteratorIterator( new RecursiveDirectoryIterator( $dir ) );
$files = array();
$assets_modification_time = array();
foreach ($riterator as $file) {
if ( ! $file->isDir() ) {
array_push( $assets_modification_time, date( "YmdHi", filemtime( $file->getPathname() ) ) );
}
}

return max( $assets_modification_time );
}

define( 'DX_ASSETS_VERSION', dx_get_assets_version( get_template_directory() . '/assets/dist/' ) );

/**
* Implement the Custom Header feature.
Expand Down