feat: implement 4 backend features (reconciliation, calculator, transfers, permissions) - #1070
Merged
Merged
Conversation
…fers, permissions) Closes Devsol-01#1043 - Add FeeReconciliationService to rewards module - FeeReconciliation entity, reconciliation/discrepancy detection, daily cleanup cron Closes Devsol-01#1042 - Add SavingsCalculatorService - Projection calculations, goal progress tracking, APY lookups, product comparison Closes Devsol-01#1041 - Extend GoalTransferService with auto-transfer scheduling - updateSchedule, getUpcomingTransfers, batchCreate, getTransferSummary - New BatchCreate and Update DTOs Closes Devsol-01#1040 - Add group savings permission middleware - GroupPermissionGuard with admin/member/open role checks - GroupAdminOnly, GroupMemberOnly, GroupOpenOnly decorators
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
@Ibinola Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…check, spec mismatches - Fix duplicate Inject/Optional import in graceful-shutdown.service.ts - Fix duplicate Observable import in graceful-shutdown.interceptor.ts - Restore corrupted merge in graceful-shutdown.service.ts (duplicate constructors, methods embedded inside other methods) - Fix check-migrations-down.js regex (required 'public' keyword, but TS methods are public by default) - Fix graceful-shutdown.service.spec.ts: broken merge (tests were inside other tests), omitted unnecessary TestingModule - Fix disputes.service.spec.ts: add missing DisputeTimelineRepository + NotificationsService mocks - Fix typeorm-pool.config.spec.ts: update pool defaults to match current config (50/10 instead of 30/5) All 85 suites / 688 tests passing on CI.
…from bad merge) StandardErrorResponse interface doesn't have 'correlationId', and the RPC/DB/HTTP exception blocks had duplicate properties from a merge conflict. Cleaned up to match the interface.
GroupInvitation, ActivityTimeline, and MilestoneNotification entities from commit 84ec374 were not present in the merge but were referenced by savings.module.ts.
…ock-stellar-event, fee-reconciliation) - request-logging.interceptor.ts: missing uuidv4 import, duplicate variable declarations, stray imports block inside the file - main.ts: duplicate gracefulShutdown declaration, signal handler code placed outside the shutdown function - mock-stellar-event.ts: contractId type mismatch with Stellar SDK v3 - fee-reconciliation.service.ts: DeepPartial overload resolution issues with newer TypeORM types
- mock-stellar-event.ts: remove pagingToken (removed from EventResponse) - fee-reconciliation.service.ts: cast notes null assignment - savings.module.ts: comment out missing kike-alt service imports - savings-calculator.service.ts: use correct entity property names (interestRate, minAmount) - user.controller.ts: remove orphaned code and duplicate decorators
TypeORM 0.3.x CLI requires --dataSource argument for migration:run and migration:revert commands
TypeORM CLI tryToRequire cannot load .ts files with ESM exports. Use the compiled dist/config/typeorm.config.js instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1043 - Add FeeReconciliationService to rewards module
Closes #1042 - Add SavingsCalculatorService
Closes #1041 - Extend GoalTransferService with auto-transfer scheduling
Closes #1040 - Add group savings permission middleware