Skip to content

chore: Update supported Python versions through copier template update #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DiamondJoseph
Copy link

@DiamondJoseph DiamondJoseph commented May 12, 2025

Adds support for Python 3.13 and drops for Python <=3.10 following the Numpy deprecation policy, and keeps dependencies, CI and infrastructure up to date with Diamond standards.

Instructions to reviewer on how to test:

  1. Ensure that CI passes on all versions to remain supported

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.34%. Comparing base (b04469b) to head (dab7661).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   99.33%   99.34%           
=======================================
  Files           4        4           
  Lines         453      455    +2     
=======================================
+ Hits          450      452    +2     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Araneidae
Copy link

I would recommend rejecting this PR merely based on the title and description. Please fix this and the corresponding commit description.

Updating the python requirement should definitely be a commit of its own.

@AlexanderWells-diamond
Copy link
Contributor

This repo also maintains a changelog.rst. I understand the copier template does away with at least some of the requirements of maintaining it, but at least a note in there to say the file should no longer be updated should be added.

@DiamondJoseph DiamondJoseph marked this pull request as draft May 12, 2025 11:16
@DiamondJoseph DiamondJoseph changed the title chore: Update copier template to latest version chore: Update supported Python versions through copier template update May 12, 2025
@DiamondJoseph
Copy link
Author

@AlexanderWells-diamond I've added a changelog entry- it looks like the change of supporting 3.13 will need to be continued upstream to epicscorelibs. This has come from wanting to support Python 3.13 in blueapi/dodal/ophyd-async in keeping with the NumPy deprecation policy.

@Araneidae the Python version support is defined in a section of the pyproject.toml that is modified by the python copier template in this update. To keep the tooling compatible and up to date, to allow future automating of updates and to prevent merge conflicts with all future updates to either, I'd like to keep them both together. Propagating those changes from the template means the whole organisation can move forward faster.

@DiamondJoseph
Copy link
Author

I've left this as a draft as epicscorelibs support is still required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants