Switch to copier template #34
Conversation
Currently not using sphinx and using mypy instead of pyright. Sphinx and pyright to be added later
This involved merging __init__.py for atip. The __main__.py files currently do nothing
Udpated pyproject.toml to fix authors
Fixed issue where exceptions raised from within exceptions where not passed the context. Added defaults for stacklevel when using warn(). Removed redundant comparison for void test function. Disabled warning for use of private functions in tests. Disabled warning for unneeded list comprehension which I believe is required. Fixed line too long
This is now done by copier template
Repopulated conftest.py with the pre-copier test setup for ATIP. Fixed error in test_toggle_calculations_and_wait_for_calculations that I made. Deleted ghost atip/ dir which shouldnt have been there and was stopping ATIP from running. Added testfixtures dependency to pyproject
Fixed issue causing test failure due to deprecation in python3.12
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34 +/- ##
=========================================
Coverage ? 93.84%
=========================================
Files ? 6
Lines ? 390
Branches ? 0
=========================================
Hits ? 366
Misses ? 24
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Now correctly points to atip_ioc_entry.py.
| identification within third-party archives. | ||
|
|
||
| Copyright 2023 Diamond Light Source Ltd. | ||
| Copyright {yyyy} {name of copyright owner} |
There was a problem hiding this comment.
Oopsie, @ptsOSL sorry I didn't review this PR earlier and catch this before it merged, but we can fix it on one of the open PRs
There was a problem hiding this comment.
If you read the preceding paragraph, it is intentional to keep the brackets and field description here.
There was a problem hiding this comment.
Ahh, my mistake! If I understand it correctly now, we are supposed to copy that line and the ones below into the header of every source file and switch out the bracketed bits when doing that, but leave them unchanged here?
There was a problem hiding this comment.
Technically, yes, but I'm not aware of people actually doing this properly...
Wait a bit and I'll see if something can be sorted out in the Copier template
Uh oh!
There was an error while loading. Please reload this page.