Skip to content

Conversation

@ptsOSL
Copy link
Collaborator

@ptsOSL ptsOSL commented Apr 4, 2025

  • Used copier template to setup sphinx docs
  • Reorganised docs into their correct files
  • Fixed some sphinx documentation referencing links which were misnamed and so the link couldnt be found.
  • Sphinx is still complaining about missing links, but I have changed the config to treat these as warnings and not errors.
  • The missing links are caused by missing documentation in the referenced python modules, so I cant do much about that.

ptsOSL added 5 commits April 4, 2025 11:54
Move info from old virtac/README.rst, virtac/FEEDBACK_SYSTEMS.rst into sphinx docs. Changed main README.rst to markdown and changed to work better with sphinx. Deleted some unused docs files. Updated conf.py to allow use of html images
Changes the names of various types so that Sphinx can add the correct link to the relevant docs. Such as changing the type callable to typing.Callable. There are many more to fix, but lots of them are due to missing docs to link to for pytac and pyAT
@ptsOSL ptsOSL requested a review from MJGaughran April 4, 2025 16:26
@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.84%. Comparing base (b91bb75) to head (acec366).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files           6        6           
  Lines         390      390           
=======================================
  Hits          366      366           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptsOSL ptsOSL force-pushed the switch-docs-to-sphinx branch from 0d4ed37 to c107575 Compare April 10, 2025 09:26
@ptsOSL
Copy link
Collaborator Author

ptsOSL commented Apr 10, 2025

Did a force push to remove two commits which cancelled each other out. I probably should have done these commits on a separate testing branch.

@ptsOSL ptsOSL changed the title Draft: Switch docs to sphinx Switch docs to sphinx Apr 10, 2025
ptsOSL added 3 commits April 10, 2025 16:06
Also add sphinx nitpick exceptions
Mostly adding missing docstrings to classes or fixing syntax. The actual docstring content has not yet been properly updated and needs a refresh which will be done later.
@ptsOSL ptsOSL merged commit b0449bf into main Apr 11, 2025
19 checks passed
@ptsOSL ptsOSL deleted the switch-docs-to-sphinx branch April 15, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants