Skip to content

feat(ViSR): Controls in a collapsible drawer for spectroscopy view - #130

Draft
Abigail-Yates wants to merge 11 commits into
mainfrom
visr-spectroscopy-plots
Draft

feat(ViSR): Controls in a collapsible drawer for spectroscopy view#130
Abigail-Yates wants to merge 11 commits into
mainfrom
visr-spectroscopy-plots

Conversation

@Abigail-Yates

@Abigail-Yates Abigail-Yates commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

This PR builds on (or replaces) PR #126 - initial layout for dynamic expanding plot divs.

PR #126

  • moves the ViSR Spectroscopy Controls into a collapsible drawer.
  • adds 'PlotFrame.tsx' to arrange the plots in a row of 4 when the drawer is expanded and a grid when it is collapsed.

This PR also

  • removes the need for PlotFrame.tsx by installing and using the react-grid-layout package (but keeps the PlotFrame.tsx file, in case it is decided it is preferred)
  • Adds the 'gray' channel to the spectroscopy view (fixes typing errors, possibly not in the way as described here https://jira.diamond.ac.uk/browse/EU-401 )
  • Fixes the resizing issues when changing browser size by changing the Box component to a div (https://jira.diamond.ac.uk/browse/EU-399 )
  • Removes the issue with different formats for the plot aspect ratio by removing the need for PlotFrame.tsx ( https://jira.diamond.ac.uk/browse/EU-400 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants