-
Notifications
You must be signed in to change notification settings - Fork 7
fix: Pass authn context into TiledWriter context #1280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
DiamondJoseph
wants to merge
21
commits into
main
Choose a base branch
from
authn-context
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d92af26 to
0f5dbc9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1280 +/- ##
==========================================
- Coverage 94.92% 94.67% -0.25%
==========================================
Files 42 42
Lines 2717 2742 +25
==========================================
+ Hits 2579 2596 +17
- Misses 138 146 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b254d68 to
cc23961
Compare
cc23961 to
d3d27ce
Compare
1f5cb3a to
6686848
Compare
d3d27ce to
29a8120
Compare
29a8120 to
493ac83
Compare
This reverts commit a0dc91807e4b48487aff535038e3de70a83e5591.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ACQP-474, ACQP-475 by passing authentication information into the TiledWriter, to allow writing to a Tiled that uses proxy OIDC authentication.
Also refactors handling of #1201/#1202