feat!: Add task_id to DataEvents #942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpoliaw
force-pushed
the
data_event_task_id
branch
from
795db99 to
82f8c98
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #942 +/- ##
=======================================
Coverage 94.84% 94.84%
=======================================
Files 41 41
Lines 2501 2502 +1
=======================================
+ Hits 2372 2373 +1
Misses 129 129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
callumforrester
approved these changes
Jun 4, 2025
tpoliaw
force-pushed
the
data_event_task_id
branch
from
82f8c98 to
f24d51a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including the task_id in the data events (wrapped messages from run engine),
allows clients to filter messages to the specific task that they are
interested.
For instance, in the "submit task => start listening to events => start task"
exchange, it is useful to be able to ignore events received before the start
task fails due to another task running.