112 fix arrow markers on line widget #113
Conversation
abigailalexander
left a comment
abigailalexander
left a comment
There was a problem hiding this comment.
I can see the arrowheads working properly now for the rules, great! I had one or two minor CSS/Phoebus differences that would be good to be implemented.
src/ui/widgets/Line/line.tsx
Outdated
| fillArrow = true | ||
| } = props; | ||
|
|
||
| const color = transparent ? "transparent" : backgroundColor.toString(); |
There was a problem hiding this comment.
The use of background colour here is part of CSStudio. In Phoebus, we no longer have a background colour (or transparent) but use lineColour instead. I'd suggest updating this to check for lineColor first, then doing the transparent/backgroundColor set next so we can cover both the CSS and phoebus use cases.
src/ui/widgets/Line/line.tsx
Outdated
| height = WIDGET_DEFAULT_SIZES["polyline"][1], | ||
| lineWidth = 3, | ||
| points, | ||
| arrowLength = 2, |
There was a problem hiding this comment.
This is another "still using the old CSS values" issue, but the default arrow length is now 20. If you load a file that uses default arrow size 20 you can't see the arrow in the web because it is too small.
| ? Color.TRANSPARENT.toString() | ||
| : backgroundColor?.toString() | ||
| } | ||
| fill={"none"} |
There was a problem hiding this comment.
This fill="none" property should be kept, otherwise I see a black background on the widget.
No description provided.