81 pv formulae not supported #116
Conversation
rjwills28
left a comment
rjwills28
left a comment
There was a problem hiding this comment.
This look really good! I've tested it out and all works really nicely. I just noticed one very minor point that could be addressed before merging - see inline comment.
src/types/pv.ts
Outdated
| // after the PV object has been created. | ||
| if (this.name.includes(PV.DELIMITER)) { | ||
| // Need to make sure that the PV.DELIMITER is not associated with a nested PV. | ||
| if (this.name.includes(PV.DELIMITER) && !this.name.includes("`")) { |
There was a problem hiding this comment.
Very minor point - it looks like you can also create a formula using a single quote (i.e. ') as well as with a backtick, e.g. =3+4*'sim://ramp'. This works in Phoebus and PVWS so maybe we could just add an addition && to check that it also doesn't include a '?
|
I added the check for single-quotes and I added an else-if for "eq://" in case the name is substituted with another PV formula. |
|
Also made that else-if check for "=". |
rjwills28
left a comment
rjwills28
left a comment
There was a problem hiding this comment.
Looks great - thanks for making those changes.
PV parser has been updated to correctly parse PV formulae and to parse PV starting with "=" to start with "eq://". "eq://" has been added to list of plugins in store.ts to enable formulae subscribe requests.