Update rotation of actionbutton and readback #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed references to diamondTheme and implemented useTheme hook * Updated snapshots * Added theme prop to embeddedDisplay widget * Renamed diamondTheme to phoebusTheme * Renamed exported theme to phoebusTheme * Use phoebusTheme as default instead of the MUI default
…-of-actionbutton-and-readback
abigailalexander
requested changes
May 22, 2025
Collaborator
abigailalexander
left a comment
abigailalexander
left a comment
There was a problem hiding this comment.
All works fine, just one suggestion regarding moving the rotation calculation into a separate function that can be reused elsewhere.
* Fixed widget rotation * Updated border styling to match phoebus and added rounded corners * Corrected offsets for 90 and -90 deg rotations * Generalise use of themes (#117) * Removed references to diamondTheme and implemented useTheme hook * Updated snapshots * Added theme prop to embeddedDisplay widget * Renamed diamondTheme to phoebusTheme * Renamed exported theme to phoebusTheme * Use phoebusTheme as default instead of the MUI default * Updated snapshots
…-of-actionbutton-and-readback
NatLeung96
merged commit 61d4317
into
80-update-widgets-to-use-mui-base
2 checks passed
NatLeung96
added a commit
that referenced
this pull request
May 22, 2025
* Updated the rotation for readback widget * Updated rotation for actionbutton * Removed commented out props * Generalise use of themes (#117) * Removed references to diamondTheme and implemented useTheme hook * Updated snapshots * Added theme prop to embeddedDisplay widget * Renamed diamondTheme to phoebusTheme * Renamed exported theme to phoebusTheme * Use phoebusTheme as default instead of the MUI default * Updated snapshot * Update label borders and rotation (#119) * Fixed widget rotation * Updated border styling to match phoebus and added rounded corners * Corrected offsets for 90 and -90 deg rotations * Generalise use of themes (#117) * Removed references to diamondTheme and implemented useTheme hook * Updated snapshots * Added theme prop to embeddedDisplay widget * Renamed diamondTheme to phoebusTheme * Renamed exported theme to phoebusTheme * Use phoebusTheme as default instead of the MUI default * Updated snapshots * Added a function for calculating width, height, and transform for rotated widgets * Implemented the new calculateRotationTransform function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes the bug with the readback widget where it appears in the wrong place when rotated -90 degrees. The rotation of the actionbutton widget has also been changed to match the rotation behaviour of the label and readback widgets.