Fix dynamic script timeouts #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
GregJHarris
commented
Nov 26, 2025
GregJHarris
commented
- Drop use of iFrameSandboxScriptRunner.onload in favour of directly setting the srcdoc of the iframe. This resolves the majority of timeouts caused by repeat triggers of onload.
- Add a flag (iFrameSandboxReady) to indicate that the sandbox IFrame is ready to receive messages. This ensures we only send messages to the IFrame when it is ready to process them.
abigailalexander
approved these changes
Nov 27, 2025
Collaborator
abigailalexander
left a comment
abigailalexander
left a comment
There was a problem hiding this comment.
Fixes the issue mentioned, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.