Fix warnings in bobParser when alarmSensitive border property is missing #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default in BOB from Phoebus is not to include this property and default to 'true'. The property is only added if false.
abigailalexander
approved these changes
Feb 6, 2025
Collaborator
abigailalexander
left a comment
abigailalexander
left a comment
There was a problem hiding this comment.
Tested and this fixes the issue mentioned, looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing a previous change in the bobParser I noticed that I was getting warnings in the console that a property could not be parsed. This didn't cause errors in the application as the property was optional.
The problem is that a BOB file generated from Phoebus by default does not include the
alarm_sensitive_borderproperty. By default this is assumed to be true and so the property is only added if the user sets it to false.I've added a separate bobParser version to use instead of the opiParser version. Also updated the tests to make sure the default version is reflected correctly.
TESTING: To test with and without this fix, use a BOB file generated by Phoebus that contains a
TextUpdatewidget.