Fix bug in FBBA analyse function to use oscillation midpoint - #87
Merged
Conversation
MichaelStubbings
requested review from
MJGaughran and
ptsOSL
and removed request for
MJGaughran and
ptsOSL
July 7, 2026 14:24
MichaelStubbings
force-pushed
the
hla-1109-fix-analysis-bug
branch
from
July 9, 2026 08:05
5fe548b to
0822110
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the analysis function in FBBA and simFBBA to plot the oscillation midpoint against the oscillation size. This is in line with what is analysed in Slow BBA.
Resolves HLA-1109.
(Some linting changes are also included to resolve pre-commit.)