Skip to content

Conversation

@Relm-Arrowny
Copy link
Contributor

@Relm-Arrowny Relm-Arrowny commented Feb 19, 2025

Fixes #1060
Unblock #1033

Instructions to reviewer on how to test:

  1. run: tox -e tests -- --durations=10 tests/devices/unit_tests/test_apple2_undulator.py
  2. Confirm timeout is less than 1s

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@Relm-Arrowny Relm-Arrowny requested a review from a team as a code owner February 19, 2025 10:02
@Relm-Arrowny Relm-Arrowny linked an issue Feb 19, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (4ca1dc0) to head (8e9a52f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1061   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files         160      160           
  Lines        6629     6629           
=======================================
  Hits         6476     6476           
  Misses        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@DominicOram DominicOram merged commit 81496ff into main Feb 19, 2025
19 checks passed
@DominicOram DominicOram deleted the 1060-apple2-test-run-time-is-too-long branch February 19, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apple2 test run time is too long.

3 participants