-
Notifications
You must be signed in to change notification settings - Fork 12
1156 remove extra release instructions #1157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1157 +/- ##
==========================================
+ Coverage 97.75% 97.81% +0.05%
==========================================
Files 172 171 -1
Lines 6870 6867 -3
==========================================
+ Hits 6716 6717 +1
+ Misses 154 150 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I got the link wrong in the original issue. https://diamondlightsource.github.io/dodal/main/developer/how-to/make-release.html is the correct release instructions.
I think we can just entirely remove this page rather than just delete the contents (and any references to it). I don't think it's useful having a page that is just empty other than the link
Sorry, something really weird is happening here. https://diamondlightsource.github.io/dodal/main/developer/how-to/make-release.html doesn't exist in the codebase so there is no duplicate? But if it's not in the codebase why can I still navigate to it? I will investigate. |
I think we probably just want to get rid of the old ones as per https://diamondlightsource.slack.com/archives/CKW8E0V4H/p1744099881688519?thread_ts=1744043386.685669&cid=CKW8E0V4H |
Ah yes, let's do that |
I think this was basically just my mistake, happy to close |
Fixes #1156
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}