Skip to content

1156 remove extra release instructions #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

jacob720
Copy link
Contributor

@jacob720 jacob720 commented Apr 1, 2025

Fixes #1156

Instructions to reviewer on how to test:

  1. Check the docs on making a release
  2. Confirm they link to the mx-bluesky docs on making a release

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@jacob720 jacob720 requested a review from a team as a code owner April 1, 2025 16:23
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.81%. Comparing base (b481ffa) to head (1a12bda).
Report is 61 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1157      +/-   ##
==========================================
+ Coverage   97.75%   97.81%   +0.05%     
==========================================
  Files         172      171       -1     
  Lines        6870     6867       -3     
==========================================
+ Hits         6716     6717       +1     
+ Misses        154      150       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I got the link wrong in the original issue. https://diamondlightsource.github.io/dodal/main/developer/how-to/make-release.html is the correct release instructions.

I think we can just entirely remove this page rather than just delete the contents (and any references to it). I don't think it's useful having a page that is just empty other than the link

@jacob720 jacob720 requested a review from DominicOram April 7, 2025 08:57
@DominicOram
Copy link
Contributor

Sorry, something really weird is happening here. https://diamondlightsource.github.io/dodal/main/developer/how-to/make-release.html doesn't exist in the codebase so there is no duplicate? But if it's not in the codebase why can I still navigate to it? I will investigate.

@DominicOram
Copy link
Contributor

I think we probably just want to get rid of the old ones as per https://diamondlightsource.slack.com/archives/CKW8E0V4H/p1744099881688519?thread_ts=1744043386.685669&cid=CKW8E0V4H

@olliesilvester
Copy link
Collaborator

Ah yes, let's do that

@DominicOram
Copy link
Contributor

I think this was basically just my mistake, happy to close

@DominicOram DominicOram closed this Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove extra release instructions
3 participants