Skip to content

Create initial analyserscan plan #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 142 commits into
base: main
Choose a base branch
from

Conversation

oliwenmandiamond
Copy link
Contributor

Create basic analyserscan plan, allowing for reading of a sequence file, configuring analyser with region settings, and saving the data for each region into separate streams.

Instructions to reviewer on how to test:

  1. Check that plan logic makes sense
  2. Make sure tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

oliwenmandiamond and others added 30 commits March 6, 2025 15:41
@oliwenmandiamond oliwenmandiamond self-assigned this Apr 30, 2025
@oliwenmandiamond oliwenmandiamond force-pushed the create_initial_analyserscan_plan branch from 728988e to eb86342 Compare April 30, 2025 12:32
@oliwenmandiamond oliwenmandiamond force-pushed the create_initial_analyserscan_plan branch from eb86342 to 78de39b Compare April 30, 2025 13:29
)


class AnalyserController(Generic[TAbstractAnalyserDriverIO]):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this class need to be a child of TAbstractAnalyserDriverIO if it gets driver of the same class TAbstractAnalyserDriverIO as a parameter?

Base automatically changed from get_detector_data_from_analyser_controller to main May 1, 2025 12:57
Copy link

codecov bot commented May 1, 2025

Codecov Report

Attention: Patch coverage is 72.54902% with 28 lines in your changes missing coverage. Please review.

Project coverage is 97.59%. Comparing base (217a70c) to head (beace20).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/dodal/devices/electron_analyser/detector.py 64.38% 26 Missing ⚠️
src/dodal/common/data_util.py 66.66% 1 Missing ⚠️
.../devices/electron_analyser/abstract_analyser_io.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
- Coverage   97.95%   97.59%   -0.36%     
==========================================
  Files         186      187       +1     
  Lines        7285     7365      +80     
==========================================
+ Hits         7136     7188      +52     
- Misses        149      177      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.