-
Notifications
You must be signed in to change notification settings - Fork 12
Create initial analyserscan plan #1205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…from generic base
* Create BaseDCM * Modify other DCM's to inherit from BaseDCM
Co-authored-by: Dominic Oram <[email protected]>
728988e
to
eb86342
Compare
eb86342
to
78de39b
Compare
) | ||
|
||
|
||
class AnalyserController(Generic[TAbstractAnalyserDriverIO]): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this class need to be a child of TAbstractAnalyserDriverIO if it gets driver of the same class TAbstractAnalyserDriverIO as a parameter?
…hod to abstract detector
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1205 +/- ##
==========================================
- Coverage 97.95% 97.59% -0.36%
==========================================
Files 186 187 +1
Lines 7285 7365 +80
==========================================
+ Hits 7136 7188 +52
- Misses 149 177 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Create basic analyserscan plan, allowing for reading of a sequence file, configuring analyser with region settings, and saving the data for each region into separate streams.
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}