Skip to content

Conversation

@DominicOram
Copy link
Contributor

Part of DiamondLightSource/mx-bluesky#1006

Instructions to reviewer on how to test:

  1. Confirm new signals added to read

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@DominicOram DominicOram requested a review from a team as a code owner May 19, 2025 21:56
@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.09%. Comparing base (e17d0b3) to head (9129b0d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1235   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files         211      211           
  Lines        7988     7990    +2     
=======================================
+ Hits         7836     7838    +2     
  Misses        152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DominicOram DominicOram merged commit a94cabd into main Jun 26, 2025
10 checks passed
@DominicOram DominicOram deleted the mx_bluesky_1006_robot_unload branch June 26, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants