Conversation
Addresses #2136 * Replaces brittle enumeration of I19 filter wheel one which was tightly coupled to interchangeable installed filters in favour of mapping to wheel slot locations. e.g. W1S4 * The mapping from slot label to absorber specifics and business logic exclusions etc has to be done outside this enum no matter what form it takes * This change renders the labelling less brittle as old label AIR5 would have become redundant when slot 5 sees a future foil filter added. * Note the abuse of an enum is (temporarily at least) a necessary evil imposed by the assumptions in the design of the standard FilterWheel class
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2137 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 354 354
Lines 13832 13832
=======================================
Hits 13716 13716
Misses 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2136
Replaces brittle enumeration of I19 filter wheel one which was tightly coupled to interchangeable installed filters in favour of mapping to wheel slot locations. e.g. W1S4
The mapping from slot label to absorber specifics and business logic exclusions etc has to be done outside this enum no matter what form it takes
This change renders the labelling less brittle as old label AIR5 would have become redundant when slot 5 sees a future foil filter added.
Note the abuse of an enum is (temporarily at least) a necessary evil imposed by the assumptions in the design of the standard FilterWheel class
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}