Skip to content

Fix flakey undulator dcm test - #2142

Open
oliwenmandiamond wants to merge 2 commits into
update_to_ophyd_async_0_20from
fix_flakey_undulator_dcm_test
Open

Fix flakey undulator dcm test#2142
oliwenmandiamond wants to merge 2 commits into
update_to_ophyd_async_0_20from
fix_flakey_undulator_dcm_test

Conversation

@oliwenmandiamond

@oliwenmandiamond oliwenmandiamond commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Fixes #2141

Have verified that it is no longer flakey using the event_loop_fuzzing fixture and ran 100 times and all passed as shown below

image

Instructions to reviewer on how to test:

  1. Check new test makes sense

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@oliwenmandiamond
oliwenmandiamond requested a review from a team as a code owner July 29, 2026 09:54
@oliwenmandiamond
oliwenmandiamond changed the base branch from main to update_to_ophyd_async_0_20 July 29, 2026 09:55
@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.16%. Comparing base (6b424b6) to head (8c6f719).

Additional details and impacted files
@@                     Coverage Diff                     @@
##           update_to_ophyd_async_0_20    #2142   +/-   ##
===========================================================
  Coverage                       99.16%   99.16%           
===========================================================
  Files                             354      354           
  Lines                           13841    13841           
===========================================================
  Hits                            13725    13725           
  Misses                            116      116           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undulator DCM has flakey test

1 participant