Skip to content

updated to most recent copier #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

evvaaaa
Copy link
Contributor

@evvaaaa evvaaaa commented Nov 20, 2024

The problems with pypi release here are fixed in copier https://github.com/DiamondLightSource/python-copier-template/releases/tag/2.5.0.

@GDYendell @jsouter (can't assign reviewers)

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.20%. Comparing base (294c93a) to head (2dd5dc3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   72.20%   72.20%           
=======================================
  Files           4        4           
  Lines         295      295           
=======================================
  Hits          213      213           
  Misses         82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jsouter jsouter requested a review from GDYendell November 20, 2024 08:02
@GDYendell
Copy link
Contributor

Actually the pypi release already didn't work because of this: https://github.com/DiamondLightSource/fastcs-eiger/blob/main/pyproject.toml#L27. We need DiamondLightSource/tickit-devices#111 (and then the eiger-stream2 branch) to be merged.

@evvaaaa evvaaaa changed the title updated to most recent copier to fix release updated to most recent copier Nov 20, 2024
@evvaaaa
Copy link
Contributor Author

evvaaaa commented Nov 20, 2024

Ah yes I saw the

ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/

and got hasty. I still think it won't work without attestations: false and it's nice to keep up to date.

@GDYendell GDYendell merged commit e9769a4 into DiamondLightSource:main Nov 20, 2024
11 checks passed
@evvaaaa evvaaaa deleted the update-copier-to-fix-pypi-release branch November 20, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants