Push code coverage to codecov

[ZohebShaikh]

No description provided.

[codecov]

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

[dan-fernandes]

Once bogus test is removed, LGTM 👍

[tpoliaw]

Can we add some config to avoid the annoying things like moving untested code causing a CI run to fail?

For numtracker I've gone for making the patch check informational only, and given a bit of leeway in the project coverage so dropping slightly is not a blocker. We should still aim for high coverage but adding pointless tests to raise coverage levels isn't the best use of time.

[DiamondJoseph]

Can we add some config to avoid the annoying things like moving untested code causing a CI run to fail?

This repo doesn't have any rules defined for what checks must pass for a PR to be mergable. I propose adding one with format/lint/test only?

[DiamondJoseph]

Implemented as such:

[ZohebShaikh]

Can we add some config to avoid the annoying things like moving untested code causing a CI run to fail?

For numtracker I've gone for making the patch check informational only, and given a bit of leeway in the project coverage so dropping slightly is not a blocker. We should still aim for high coverage but adding pointless tests to raise coverage levels isn't the best use of time.

I did not add any config to make the coverage information is because currently it is just information in both numtracker and glazed because they are not merge blockers(required)

It just gives the reviewer some warning before merging to see if there were some test that could have been added which are missing ..rather than adding mockeypatch tests just to increase coverage.

Happy to add the information codecov in CI to make it information but I think then it should added to the python copier template as well to make it a Diamond wide policy

[ZohebShaikh]

@abbiemery Are you okay with this going in ? I was told by @dan-fernandes to check with you