Skip to content

Conversation

@tpoliaw
Copy link
Contributor

@tpoliaw tpoliaw commented Dec 1, 2025

Reduce the query space to searching by instrument session for runs and
within runs for data.

Stops the API being as tightly coupled to the internal structure of
tiled.

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 2.82486% with 172 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.02%. Comparing base (01f835d) to head (813dd6a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/model.rs 0.00% 64 Missing ⚠️
src/download.rs 0.00% 58 Missing ⚠️
src/clients.rs 7.31% 38 Missing ⚠️
src/main.rs 0.00% 7 Missing ⚠️
src/model/container.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #75       +/-   ##
===========================================
- Coverage   74.70%   37.02%   -37.69%     
===========================================
  Files          12       12               
  Lines         514      443       -71     
===========================================
- Hits          384      164      -220     
- Misses        130      279      +149     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@abbiemery abbiemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, this is the first pass of getting an interface that delivers us what we want. To avoid holding things up I think we get this in. Remove the test todo and write tests in a following pr. If time permits before friday grand. If not, we can do them once we reorganise this somewhat.

@abbiemery abbiemery added this to the 0.1.0 - First Release milestone Dec 2, 2025
@tpoliaw tpoliaw changed the title Combined data Rework API to reflect use cases more than tiled structure Dec 2, 2025
@abbiemery abbiemery changed the title Rework API to reflect use cases more than tiled structure Rework API to reflect desired user interface Dec 2, 2025
@tpoliaw tpoliaw merged commit 63139f9 into main Dec 2, 2025
5 of 7 checks passed
@tpoliaw tpoliaw deleted the combined_data branch December 2, 2025 12:37
@tpoliaw tpoliaw linked an issue Dec 2, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Instrument and InstrumentSession objects

3 participants