-
Notifications
You must be signed in to change notification settings - Fork 1
Rework API to reflect desired user interface #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
And make file assets a list of assets instead of two lists of files and downloads
To allow download links to be based on reality
Re-use TiledClient so that URL isn't hardcoded. And errors are forwarded correctly.
If columns aren't given, all data is returned
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
===========================================
- Coverage 74.70% 37.02% -37.69%
===========================================
Files 12 12
Lines 514 443 -71
===========================================
- Hits 384 164 -220
- Misses 130 279 +149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
abbiemery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, this is the first pass of getting an interface that delivers us what we want. To avoid holding things up I think we get this in. Remove the test todo and write tests in a following pr. If time permits before friday grand. If not, we can do them once we reorganise this somewhat.
Reduce the query space to searching by instrument session for runs and
within runs for data.
Stops the API being as tightly coupled to the internal structure of
tiled.