Continue with query when some fields are raise errors #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## tiled-error-tolerance #82 +/- ##
======================================================
Coverage 49.64% 49.64%
======================================================
Files 13 13
Lines 560 560
======================================================
Hits 278 278
Misses 282 282 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
If the data for a single run could not be found, it should not prevent the data for other runs being returned. The way async-graphql handles this is... odd. By making the resolver return an Option<Result<T,E>> but only ever actually returning a Some(_) variant, errors are added to the errors list in the response and the rest of the query is executed as expected. Adding the extra Option layer breaks error handling via the ? operator which would make the resolver noisy so the inner logic is moved into a non-object impl block which can then be called and wrapped by the graphql macro wrapped version of the same method.
abbiemery
approved these changes
Dec 3, 2025
Contributor
abbiemery
left a comment
abbiemery
left a comment
There was a problem hiding this comment.
The combination of these prs makes things much nicer. Tests would be good with a combined call that has successes and errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the data for a single run could not be found, it should not prevent
the data for other runs being returned.
The way async-graphql handles this is... odd. By making the resolver
return an
Option<Result<T,E>>but only ever actually returning aSome(_)variant, errors are added to the errors list in the responseand the of the query is executed as expected.
Adding the extra
Optionlayer breaks error handling via the ? operatorwhich would make the resolver noisy so the inner logic is moved into a
non-object impl block which can then be called and wrapped by the
graphql macro wrapped version of the same method.