Ensure build in container uses latest source #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, cargo's rebuild-needed check doesn't pick up that the source has been replaced after the initial cache warm-up build.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
=======================================
Coverage 50.55% 50.55%
=======================================
Files 12 12
Lines 544 544
=======================================
Hits 275 275
Misses 269 269 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
More discussion of it here. I think I missed this with the same change in numtracker as that has a build script which would have triggered the rebuild as well. |
DiamondJoseph
approved these changes
Dec 3, 2025
Contributor
DiamondJoseph
left a comment
DiamondJoseph
left a comment
There was a problem hiding this comment.
That's so computers
Contributor
|
🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, cargo's rebuild-needed check doesn't pick up that
the source has been replaced after the initial cache warm-up build.