Skip to content

Conversation

@ferenc-rad
Copy link
Collaborator

Excludes intermediate python files, not to be version controlled

@ferenc-rad ferenc-rad requested a review from dkazanc April 25, 2025 12:37
Copy link
Contributor

@yousefmoazzam yousefmoazzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine to me!

In addition to addressing the missing newline character, could you also fix the typo in the commit message: "gitinore" should be "gitignore".

Excludes intermediate python files, not to be version controlled
@ferenc-rad ferenc-rad changed the title Add a gitinore file Add a gitignore file Apr 29, 2025
Copy link
Contributor

@yousefmoazzam yousefmoazzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 🙂

@yousefmoazzam yousefmoazzam merged commit 47e2bfe into main Apr 29, 2025
2 checks passed
@yousefmoazzam yousefmoazzam deleted the gitignore branch April 29, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants