Skip to content

LPRec memory estimator update with options #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 3, 2025
Merged

LPRec memory estimator update with options #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
783cf73
Add options
neon60 Sep 30, 2025
780d916
Pass all tests with power of 2 oversampling
neon60 Oct 2, 2025
9258aac
Update center_size value
neon60 Oct 2, 2025
2700905
Improve for min mem options at LPRec
neon60 Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 51 additions & 24 deletions ...kends/methods_database/packages/backends/httomolibgpu/supporting_funcs/recon/algorithm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,9 @@ def _calc_memory_bytes_LPRec3d_tomobar(
else:
detector_pad = 0

min_mem_usage_filter = False
min_mem_usage_ifft2 = False

angles_tot = non_slice_dims_shape[0]
DetectorsLengthH_prepad = non_slice_dims_shape[1]
DetectorsLengthH = non_slice_dims_shape[1] + 2 * detector_pad
Expand All @@ -195,8 +198,8 @@ def _calc_memory_bytes_LPRec3d_tomobar(
)
)

center_size = 6144
center_size = min(center_size, n * 2 + m * 2)
center_size = 32768
center_size = min(center_size, n * 2)

oversampling_level = 2 # at least 2 or larger required
ne = oversampling_level * n
Expand Down Expand Up @@ -252,7 +255,7 @@ def _calc_memory_bytes_LPRec3d_tomobar(
irfft_result_size = angles_tot * (n + padding_m * 2) * np.float32().itemsize

datac_size = angles_tot * n * np.complex64().itemsize / 2
fde_size = (2 * m + 2 * n) * (2 * m + 2 * n) * np.complex64().itemsize / 2
fde_size = 2 * n * 2 * n * np.complex64().itemsize / 2
fft_plan_slice_size = (
cufft_estimate_1d(nx=n, fft_type=CufftType.CUFFT_C2C, batch=angles_tot * SLICES)
/ SLICES
Expand All @@ -270,7 +273,7 @@ def _calc_memory_bytes_LPRec3d_tomobar(
)
ifft2_plan_slice_size = (
cufft_estimate_2d(
nx=(2 * m + 2 * n), ny=(2 * m + 2 * n), fft_type=CufftType.CUFFT_C2C
nx=2 * n, ny=2 * n, fft_type=CufftType.CUFFT_C2C
)
/ 2
)
Expand Down Expand Up @@ -309,24 +312,40 @@ def add_to_memory_counters(amount, per_slice: bool):
add_to_memory_counters(scaled_filter_size, False)

add_to_memory_counters(tmp_p_input_slice, True)
if min_mem_usage_filter:
add_to_memory_counters(rfft_plan_slice_size / 4, False)
add_to_memory_counters(irfft_plan_slice_size / 4, False)
add_to_memory_counters(padded_tmp_p_input_slice, False)

add_to_memory_counters(rfft_result_size, False)
add_to_memory_counters(filtered_rfft_result_size, False)
add_to_memory_counters(-rfft_result_size, False)
add_to_memory_counters(-padded_tmp_p_input_slice, False)

add_to_memory_counters(irfft_scratch_memory_size, False)
add_to_memory_counters(-irfft_scratch_memory_size, False)
add_to_memory_counters(irfft_result_size, False)
add_to_memory_counters(-filtered_rfft_result_size, False)

add_to_memory_counters(-irfft_result_size, False)
else:
add_to_memory_counters(rfft_plan_slice_size / chunk_count * 2, True)
add_to_memory_counters(irfft_plan_slice_size / chunk_count * 2, True)
# add_to_memory_counters(irfft_scratch_memory_size / chunk_count, True)
for _ in range(0, chunk_count):
add_to_memory_counters(padded_tmp_p_input_slice / chunk_count, True)

add_to_memory_counters(rfft_plan_slice_size / chunk_count * 2, True)
add_to_memory_counters(irfft_plan_slice_size / chunk_count * 2, True)
# add_to_memory_counters(irfft_scratch_memory_size / chunk_count, True)
for _ in range(0, chunk_count):
add_to_memory_counters(padded_tmp_p_input_slice / chunk_count, True)

add_to_memory_counters(rfft_result_size / chunk_count, True)
add_to_memory_counters(filtered_rfft_result_size / chunk_count, True)
add_to_memory_counters(-rfft_result_size / chunk_count, True)
add_to_memory_counters(-padded_tmp_p_input_slice / chunk_count, True)
add_to_memory_counters(rfft_result_size / chunk_count, True)
add_to_memory_counters(filtered_rfft_result_size / chunk_count, True)
add_to_memory_counters(-rfft_result_size / chunk_count, True)
add_to_memory_counters(-padded_tmp_p_input_slice / chunk_count, True)

add_to_memory_counters(irfft_scratch_memory_size / chunk_count, True)
add_to_memory_counters(-irfft_scratch_memory_size / chunk_count, True)
add_to_memory_counters(irfft_result_size / chunk_count, True)
add_to_memory_counters(-filtered_rfft_result_size / chunk_count, True)
add_to_memory_counters(irfft_scratch_memory_size / chunk_count, True)
add_to_memory_counters(-irfft_scratch_memory_size / chunk_count, True)
add_to_memory_counters(irfft_result_size / chunk_count, True)
add_to_memory_counters(-filtered_rfft_result_size / chunk_count, True)

add_to_memory_counters(-irfft_result_size / chunk_count, True)
add_to_memory_counters(-irfft_result_size / chunk_count, True)

add_to_memory_counters(-padded_in_slice_size, True)
add_to_memory_counters(-filter_size, False)
Expand All @@ -342,17 +361,25 @@ def add_to_memory_counters(amount, per_slice: bool):

add_to_memory_counters(-fft_result_size, True)

add_to_memory_counters(ifft2_plan_slice_size / chunk_count * 2, True)
for _ in range(0, chunk_count):
add_to_memory_counters(fde_size / chunk_count, True)
add_to_memory_counters(-fde_size / chunk_count, True)
if min_mem_usage_ifft2:
add_to_memory_counters(ifft2_plan_slice_size, False)
add_to_memory_counters(fde_size * 2, False)
add_to_memory_counters(-fde_size * 2, False)
else:
add_to_memory_counters(ifft2_plan_slice_size / chunk_count * 2, True)
for _ in range(0, chunk_count):
add_to_memory_counters(fde_size / chunk_count, True)
add_to_memory_counters(-fde_size / chunk_count, True)

add_to_memory_counters(recon_output_size, True)
add_to_memory_counters(-fde_size, True)
add_to_memory_counters(circular_mask_size, False)
add_to_memory_counters(after_recon_swapaxis_slice, True)

return (tot_memory_bytes * 1.05, fixed_amount + 250 * 1024 * 1024)
if min_mem_usage_ifft2 and min_mem_usage_filter:
return (tot_memory_bytes * 1.1 + 30 * 1024 * 1024, fixed_amount)
else:
return (tot_memory_bytes, fixed_amount)


def _calc_memory_bytes_SIRT3d_tomobar(
Expand Down
2 changes: 1 addition & 1 deletion tests/test_httomolibgpu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ def __test_recon_LPRec3d_tomobar_memoryhook_common(
# the estimated_memory_mb should be LARGER or EQUAL to max_mem_mb
# the resulting percent value should not deviate from max_mem on more than 20%
assert estimated_memory_mb >= max_mem_mb
assert percents_relative_maxmem <= 80
assert percents_relative_maxmem <= 85


@pytest.mark.cupy
Expand Down
Loading