Skip to content

Conversation

@dkazanc
Copy link
Collaborator

@dkazanc dkazanc commented May 8, 2025

Agnostic loader template is currently substituted by default in tests for full pipelines. Some datasets, however, do not adhere to NXTomo standard, hence the changes bellow.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation

@dkazanc dkazanc changed the title Loader related corrections for full-pipeline tests full pipelines tests fix and agnostic loader changes to tests May 20, 2025
@dkazanc
Copy link
Collaborator Author

dkazanc commented May 20, 2025

This PR fixes all tests with respect to changes in the backends here.
All tests pass apart from the sweeping CoR one, which is a different issue.

@dkazanc
Copy link
Collaborator Author

dkazanc commented May 20, 2025

@yousefmoazzam OK, I think this is done now with the small data and framework (ui_layer) tests fixed. The only one test in the framework that is failing for me is:
FAILED tests/test_cli.py::test_cli_noargs_shows_help - assert 0 == 2
Any ideas why? Thanks

@yousefmoazzam
Copy link
Collaborator

@yousefmoazzam OK, I think this is done now with the small data and framework (ui_layer) tests fixed. The only one test in the framework that is failing for me is: FAILED tests/test_cli.py::test_cli_noargs_shows_help - assert 0 == 2 Any ideas why? Thanks

If you mean that the test is failing for you when running locally, can you try updating click to version 8.2.0 (see #587 for more details).

@dkazanc
Copy link
Collaborator Author

dkazanc commented May 20, 2025

thanks, that resolved it!

@dkazanc dkazanc merged commit d726a34 into main May 28, 2025
3 of 4 checks passed
@dkazanc dkazanc deleted the testsbig branch May 28, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants