Skip to content

Conversation

@mfep
Copy link
Collaborator

@mfep mfep commented Nov 19, 2025

  • Copied remove_stripe_fw implementation from https://gitlab.esrf.fr/tomotools/nabu/-/blob/master/nabu/thirdparty/tomocupy_remove_stripe.py#L311
    • Updated the original implementation so that trivial computations are not offloaded to the GPU
    • Note, that the implementation uses the PyWavelets dependency, which was already part of the httomo dependency chain, so this implementation keeps using it
  • Added simple regression test to check that the result of the algorithm does not change
  • Added simple regression test in zenodo-tests
  • Implemented inline device memory peak calculation, which can be run by a bool flag passed to remove_stripe_fw
    • The memory peak calculation does not perform the stripe removal and does not use the GPU at all
    • The inline implementation's advantage is that the memory estimation path can reuse the same computed values that the regular path would use. Otherwise it would be difficult to estimate the memory peak of an iterative algorithm like this
    • A unit test is added for the calculator, that proves that it is accurate with a margin of +/- 1%

@mfep mfep force-pushed the remove-stripe-fw-radway-58 branch from b2f4033 to ad4d7bd Compare December 1, 2025 13:20
@mfep mfep force-pushed the remove-stripe-fw-radway-58 branch from d99df23 to 577610b Compare December 3, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants