Adds ability to read the lookup table for beam_centre X and Y - #161
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 98.77% 98.82% +0.05%
==========================================
Files 34 34
Lines 652 681 +29
==========================================
+ Hits 644 673 +29
Misses 8 8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Matt-Carre
changed the title
noemifrisina
requested changes
Jun 18, 2026
|
|
||
|
|
||
| def _read_eiger_lookup_table(): | ||
| return config_client().get_file_contents( |
Collaborator
There was a problem hiding this comment.
Should: we don't need to import the config_client directly, there is a dodal util called get_config_client that will do that for us
|
|
||
| def _read_eiger_lookup_table(): | ||
| return config_client().get_file_contents( | ||
| "/dls_sw/i19-2/software/daq_configuration/lookup/" |
Collaborator
There was a problem hiding this comment.
Should: can we have a constant for this path?
noemifrisina
approved these changes
Jul 23, 2026
noemifrisina
left a comment
noemifrisina
left a comment
Collaborator
There was a problem hiding this comment.
Ended up making a couple changes to account for a few updates over the last month or so
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to branch 160_config_server in dodal, closes #160