Complete a simple first version of a serial collection with eiger - #172
Open
noemifrisina wants to merge 25 commits into
Open
Complete a simple first version of a serial collection with eiger#172noemifrisina wants to merge 25 commits into
noemifrisina wants to merge 25 commits into
Conversation
…amline-eiger-test
… has been plugged into the panda
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
+ Coverage 98.86% 98.88% +0.02%
==========================================
Files 34 34
Lines 704 719 +15
==========================================
+ Hits 696 711 +15
Misses 8 8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
noemifrisina
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing on the beamline on 27/07.
Note that the logic for using the series_length and splitting collection in different detector arms has not yet been added in order to make the first round of testing easier to debug.
Also closes #18 and moves the OUTENC1 on the panda to INENC3.VAL (where the new phi axis is plugged in)